fix agent.config#28
Merged
Merged
Conversation
kezhenxu94
reviewed
Sep 19, 2021
| # Apache Dubbo provider collect `arguments` in RPC call, use `Object#toString` to collect `arguments`. | ||
| plugin.dubbo.collect_provider_arguments=${SW_PLUGIN_DUBBO_COLLECT_PROVIDER_ARGUMENTS:false} | ||
| # When `plugin.dubbo.provider_consumer_arguments` is `true`, Arguments of length from the front will to the OAP backend | ||
| plugin.dubbo.consumer_provider_length_threshold=${SW_PLUGIN_DUBBO_CONSUMER_PROVIDER_LENGTH_THRESHOLD:256} |
Member
There was a problem hiding this comment.
Also update the typo in line 221
Member
|
FYI @kezhenxu94 When you have time, let's add some skip mechanism back to this new repo. |
wu-sheng
reviewed
Sep 20, 2021
Comment on lines
-31
to
+38
| - name: "Dynamic Configurations" | ||
| path: "/en/setup/service-agent/java-agent/configurations#dynamic-configurations" | ||
| - name: "Optional Plugins" | ||
| path: "/en/setup/service-agent/java-agent/readme#optional-plugins" | ||
| - name: "Bootstrap/JVM class plugin" | ||
| path: "/en/setup/service-agent/java-agent/readme#bootstrap-class-plugins" | ||
| - name: "Agent Configuration Properties" | ||
| path: "/en/setup/service-agent/java-agent/configurations#table-of-agent-configuration-properties" | ||
| - name: "Dynamic Configurations" | ||
| path: "/en/setup/service-agent/java-agent/configurations#dynamic-configurations" |
wu-sheng
approved these changes
Sep 20, 2021
kezhenxu94
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Follow the doc to readjust the order of agent.config and fix the mismatched naming between the doc and the agent.config.